-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality and Stability Improvements #21
Open
AndrewDongminYoo
wants to merge
16
commits into
techinpark:master
Choose a base branch
from
AndrewDongminYoo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request incorporates multiple fixes, enhancements, and chore tasks to improve the overall quality, stability, and maintainability of the
appstore-status-bot
project.Summary of Changes
Bug Fixes
Fix Extensions
Resolved extension issues in the following modules:
check_status.js
discord.js
slack.js
Type Conversion
Addressed type conversion issues in
check_status.js
.Error Repeating State Change
Fixed a bug where state changes were incorrectly repeated every 15 minutes (
===
comparison error). Affected files:check_status.js
discord.js
slack.js
Module Resolution
Fixed a "module not found" error in
check_status.js
.__dirname
in ES ModulesResolved the issue with
__dirname
being undefined in the ES module scope. Updated:check_status.js
discord.js
slack.js
Require of ES Module
Fixed compatibility issues with ES module imports across:
check_status.js
discord.js
slack.js
eslint.config.mjs
README.md
.Replace
node-fetch
withaxios
Improved HTTP request handling by migrating from
node-fetch
toaxios
indiscord.js
.Vulnerability Fixes
request
package withaxios
due to vulnerabilities.Gemfile.lock
.Enhancements
Environment Shortcut Setup
Introduced environment variable shortcuts for easier configuration. Added
env.js
.Node Version Upgrade
Upgraded Node.js version in
.github/workflows/fetch.yml
for better performance and compatibility.Documentation
Typos Fixed
Fixed typos in:
README.md
README-JAPANESE.md
README-KOREAN.md
ESLint Installation
Installed and configured ESLint (
eslint.config.mjs
) to ensure consistent code quality.Chores
Source Code Formatting
Reformatted all source files for consistent style:
NPM Type to ES Module
Updated
package.json
to properly use ES modules.Workflow Updates
Fixed workflow file configurations in
.github/workflows/fetch.yml
and.github/FUNDING.yml
.Additional Changes
Added ESLint Configuration
Integrated ESLint with a new configuration file to enforce code quality standards.
Updated Images
Adjusted GitHub-related images for consistency:
og.png
preview.png
preview_ko.png
Testing and Verification
Impact
These changes significantly improve the bot's reliability, maintainability, and adherence to modern development practices.