poc: Websockets for user notifications #1460
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| lock: pip-tools | ||
| CUSTOM_COMPILE_COMMAND="make lock" pip-compile --upgrade --generate-hashes --strip-extras --resolver=backtracking --output-file requirements.txt requirements/base.in requirements/deploy.in | ||
| CUSTOM_COMPILE_COMMAND="make lock" pip-compile --allow-unsafe --upgrade --generate-hashes --strip-extras --resolver=backtracking --output-file requirements.txt requirements/base.in requirements/deploy.in |
Member
There was a problem hiding this comment.
question: what do we need --allow-unsafe for?
| context: . | ||
| dockerfile: Dockerfile.dev | ||
| command: python terraso_backend/manage.py runserver 0.0.0.0:${PORT} | ||
| command: daphne -b 0.0.0.0 -p ${PORT} "terraso_backend.config.asgi:application" |
Member
There was a problem hiding this comment.
question: on render, we have
Optionally override your Dockerfile's CMD and ENTRYPOINT instructions with a different command to start your service.
gunicorn --pythonpath=terraso_backend/ config.wsgi -b 0.0.0.0:${PORT}
With this change, can we eliminate this override? Or do we change it to something else?
| ids = [member.id for member in members] | ||
| users = set(users + ids) | ||
| for user_id in users: | ||
| notify_user(user_id, f"Updated: {self.mapbox_tileset_id}") |
Member
There was a problem hiding this comment.
question: should the message be structured data?
suggestion: indicate that a tileset was updated. we may have other kinds of updates in the future.
| shared_resource.target.membership_list.members.all() | ||
| ) # TODO Get only approved memberships | ||
| ids = [member.id for member in members] | ||
| users = set(users + ids) |
Member
There was a problem hiding this comment.
question: users appears to be empty. should this be set(ids)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issues
Fixes #....
Verification steps