Enhanced (SelectField) demo filtering logic and form handling... #635
Conversation
…ction Fixed (SelectField) focus management when used within dialogs Enhanced (MultiSelect/MultiSelectField/MultiSelectMenu) demo examples with functional item creation dialogs Enhanced (NumberStepper) documentation with prefix/suffix slot examples Enhanced (SelectField) demo filtering logic and form handling
|
|
🦋 Changeset detectedLatest commit: 4575db7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
.changeset/eager-walls-admire.md
Outdated
| 'svelte-ux': patch | ||
| --- | ||
|
|
||
| Fixed (Dialog/Drawer) event propagation preventing outside click detectionFixed (SelectField) focus management when used within dialogsEnhanced (MultiSelect/MultiSelectField/MultiSelectMenu) demo examples with functional item creation dialogsEnhanced (NumberStepper) documentation with prefix/suffix slot examplesEnhanced (SelectField) demo filtering logic and form handling |
There was a problem hiding this comment.
@MaCleodWalker can you split these into separate files (needed for CHANGELOG). Thanks!
There was a problem hiding this comment.
Sorry I'm not familiar with Changesets, Is this what you mean?
There was a problem hiding this comment.
It is, thanks. Left a few comments to tweak the messages themselves, but the separate changeset files for each change is exactly what I was looking for. Thanks!
| 'svelte-ux': patch | ||
| --- | ||
|
|
||
| Fixed (Dialog/Drawer) event propagation preventing outside click detection |
There was a problem hiding this comment.
Can you update the changeset to:
fix(Dialog/Drawer): event propagation preventing outside click detection
I try to follow conventional commits formatting for changesets, similar to Svelte / others
| 'svelte-ux': patch | ||
| --- | ||
|
|
||
| Enhanced (MultiSelect/MultiSelectField/MultiSelectMenu) demo examples with functional item creation dialogs |
There was a problem hiding this comment.
Can you update to:
docs(MultiSelect/MultiSelectField/MultiSelectMenu): Enhanced demo examples with functional item creation dialogs
and similar for the other doc examples.
Thanks!
| on:mouseup={(e) => { | ||
| e.stopPropagation(); // Prevent mouseup from bubbling to outside click handlers (e.g., Popover/Menu clickOutside) | ||
| }} |
There was a problem hiding this comment.
Could you show the example(s) where this was broken? Just so I can see the before/after. I'm not surprised to have to add this as event propagation is challenging, and wanted to do some regression testing as well.
There was a problem hiding this comment.
Screencast_20250811_171911.webm
There was a problem hiding this comment.
When I updated it before i used tab on my keyboard so I didn't notice that when you click anything in the dialog the select field closes.
Enhanced (MultiSelect/MultiSelectField/MultiSelectMenu) demo examples with functional item creation dialogs
Enhanced (NumberStepper) documentation with prefix/suffix slot examples
Fixed (Dialog/Drawer) event propagation preventing outside click detection
Fixed (SelectField) focus management when used within dialogs