overcome certificate authentication using local mongodb in developmen…#1
overcome certificate authentication using local mongodb in developmen…#1
Conversation
Anton-Cao
left a comment
Anton-Cao
left a comment
There was a problem hiding this comment.
Good work! Left a few small notes about removing leftover comments, and storing the event info in config.json rather than hardcoding it into the frontend.
auth-server/auth.php
Outdated
| // $name = "Anurag Golla" | ||
| // $token = "" | ||
| // $redirect_url = $login_url . '?email=' . $email . '&name=' . $name . '&token=' . $token; | ||
| // } |
There was a problem hiding this comment.
could you remove these comments to keep the code clean?
client/assets/js/home-controller.js
Outdated
| }) | ||
| }); | ||
|
|
||
| $scope.target = new Date("May 18, 2019 19:00:00").getTime(); |
There was a problem hiding this comment.
i think it would be better for the date to be set in config.json and fetched from the server through an http request rather than hard-coded into the frontend
client/views/home.html
Outdated
|
|
||
| <!-- countdown timer --> | ||
| <center> | ||
| <h1>COUNTDOWN TO PROJXPO 2019!</h1> |
There was a problem hiding this comment.
ProjX teams actually demo twice a year haha, once at xFair in February and once at ProjXpo in May. It would be helpful to have the name of the current upcoming event (ie. xFair/ProjXpo 2019) stored in config.json as well, so that the frontend can fetch that information.
| "sweetalert": "^1.1.3" | ||
| }, | ||
| "devDependencies": { | ||
| "gulp": "^3.9.0", |
There was a problem hiding this comment.
i forgot - why was this line deleted?
server/routes/user.js
Outdated
| // var key = 0 | ||
| var url = '/api/user/login' | ||
| res.redirect(url) | ||
| // res.status(200).send(url + '?key=' + key) |
There was a problem hiding this comment.
remove unnecessary comments to keep code clean 😄
There was a problem hiding this comment.
also, semicolons for consistency
server/routes/user.js
Outdated
| // req.session.isAdmin = newUser.isAdmin; | ||
| // res.redirect('/portal'); | ||
| // } | ||
| // }); |
Anton-Cao
left a comment
Anton-Cao
left a comment
There was a problem hiding this comment.
Extra comments about adding semicolons.
server/routes/user.js
Outdated
| // var key = 0 | ||
| var url = '/api/user/login' | ||
| res.redirect(url) | ||
| // res.status(200).send(url + '?key=' + key) |
There was a problem hiding this comment.
also, semicolons for consistency
server/routes/user.js
Outdated
| } else { | ||
| // FORCE log in successful | ||
| const email = config.devEmail | ||
| const name = config.devName |
There was a problem hiding this comment.
semicolons for consistency
… information for countdown timer
Anton-Cao
left a comment
Anton-Cao
left a comment
There was a problem hiding this comment.
New API routes look good! Left a comment to update the example config.json in the readme so future devs know what fields to include.
Also, I'm running into an issue where pressing "login" doesn't redirect me to the home page and I have to manually change the URL - if you are facing this problem too, can you push a fix?
|
|
||
| 8. Change `mongoUri` in `config.json` from `"data"` to `"mongodb://localhost:27017/projx"`. | ||
|
|
||
| 9. For development start, run `$ mongod` in one terminal and `$ gulp` in another terminal in the directory of the projx folder. No newline at end of file |
There was a problem hiding this comment.
Great documentation - make sure to update the example config.json so that it includes devName, devEmail, upcomingEventName, and upcomingEventDate as well.
This reverts commit 61d4927. added admin decision and contact person functionality try 2
2 participants
overcome certificate authentication using local mongodb in development mode.
Added mailto link for mentors and personal development mode information