-
Notifications
You must be signed in to change notification settings - Fork 29
Update report-book-parameters.md #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…andaloneDesigner.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use snippets from the CodeSnippets in Reporting solution
|
||
{{source=CodeSnippets\CS\API\Telerik\Reporting\ReportSourceSnippets.cs region=Set_Values_For_Unique_Or_Mergable_ReportParameters_In_ReportSource_Snippet}} | ||
{{source=CodeSnippets\VB\API\Telerik\Reporting\ReportSourceSnippets.vb region=Set_Values_For_Unique_Or_Mergable_ReportParameters_In_ReportSource_Snippet}} | ||
````C# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is much better to continue referencing the code from the CodeSnippets in the Reporting solution. Just fix the code there if necessary.
To avoid duplicating variables, use different scopes and regions. For example:
int a = 0;
if (a == 0)
{
#region 1
// code snippet 1 here
#endregion
} else if (a == 1)
{
#region 2
// code snippet 2 here
#endregion
}
etc.
@todorarabadzhiev and @IvetNikolova is this PR still needed? The added information seems to provide additional guidance. Can we move forward with implementing the changes requested by Toshko? |
No description provided.