serviceerror: add error checking helpers #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Oct 20, 2025
tdeebswihart
added a commit
that referenced
this pull request
Oct 21, 2025
This reverts commit 981440d.
tdeebswihart
added a commit
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds convenience methods for checking whether an error is the specified service error type.
Why?
It's common for us to check against the type of a service error when dealing with RPC results, but we need to be careful to use errors.Is instead of errors.As.
This adds explicit helpers akin to
os.IsNotExistthat remove any ambiguity. I found two bugs in one of our code bases in the course of writing this; I'll eliminate them once this has landedHow did you test
N/A
Potential risks
None, as these are not yet in use.