-
Notifications
You must be signed in to change notification settings - Fork 56
pause: add pause activity information to workflow describe cmd #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next-server
Are you sure you want to change the base?
Conversation
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Updating `next-server` branch with changes to `main` ## Why? Consistency ## Checklist <!--- add/delete as needed ---> 1. Closes: NA 2. How was this tested: NA 3. Any docs updates needed? No --------- Co-authored-by: Andrew Yuan <[email protected]> Co-authored-by: Chetan Gowda <[email protected]> Co-authored-by: Maciej Dudkowski <[email protected]> Co-authored-by: Carly de Frondeville <[email protected]>
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed * The `temporal activity {pause,update-options}` support batch operations through `--query` * Consistently passing the `--identity` parameter to server requests ## Why? Improved developer experience, can batch these requests through a visibility query instead of sending multiple requests ## Checklist <!--- add/delete as needed ---> 1. Closes: N/A 2. How was this tested: New unit tests 3. Any docs updates needed? Documentation updates are automatically generated with releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending discussions on the API itself (so can't mark approved yet)
} | ||
|
||
if pauseInfo := resp.GetWorkflowPauseInfo(); pauseInfo != nil { | ||
cctx.Printer.Println(color.MagentaString("Paused Activities: %v", len(pauseInfo.GetActivityPauseInfos()))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned in other context, but this isn't actually "paused activities" IMO, that is shown in "pending activities that are paused" above, this is "settings for future activity pausing".
What was changed
temporal workflow describe
command. ShowsPaused
status,PauseTime
, andPausedBy
fields when activities are paused.temporal workflow describe
Why?
Users get visibility into whether activities are paused when troubleshooting workflow execution issues.
Checklist
Closes #[issue-number]
How was this tested:
Run
temporal workflow describe
on workflows with paused activities to verify pause information displays correctly.Any docs updates needed?
No documentation updates required - this is additional output in existing command.
Requires this server pr to be merged first