Create worker deployment based versioning sample #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
requested review from
a team,
antmendoza and
tsurdilo
as code owners
Sushisource
force-pushed
the
worker-versioning-sample
branch
from
856c85a to
6547bfe
Compare
| return moreData; | ||
| } | ||
|
|
||
| public void setCalledBy(String calledBy) { |
Contributor
There was a problem hiding this comment.
Not how I would personally recommend a user create an input type, I would recommend annotating the constructor
Member
Author
There was a problem hiding this comment.
I was looking for something like that and couldn't find it. Thanks
|
|
||
| ## Steps to run this sample: | ||
|
|
||
| 1) Run a [Temporal service](https://github.com/temporalio/samples-java/tree/main/#how-to-use). |
Contributor
There was a problem hiding this comment.
What happens if the user is on an old version of Temporal that doesn't support worker versioning or it isn't enabled? Will this sample fail with a clear error they need to enable it?
Member
Author
There was a problem hiding this comment.
It's enabled by default at this point, so the main thing is just to make sure they have a recent version. I've added that to the readme.
Quinn-With-Two-Ns
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updating (adding in this case) versioning samples in all langauges
Why?
Checklist
Closes
How was this tested: