Move telemetry into common and worker config from common to core #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
move-telem-to-common
branch
from
ea09d68 to
326089e
Compare
Sushisource
changed the title
Sushisource
force-pushed
the
move-telem-to-common
branch
3 times, most recently
from
c5d204a to
167ddca
Compare
Sushisource
force-pushed
the
move-telem-to-common
branch
from
167ddca to
2a137b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves telemetry pieces into common that users would need to be able to get client metrics without also bringing in core. It also eliminates the worker trait (which was no longer used as a trait at all) and moves (core) worker config into core.
It introduces a new compile time flag for some things that wouldn't be needed in that situation (but are needed by Core).
There is also some internal simplification of meter usage