Add more Nexus operation timeouts.#1942
Merged
Quinn-With-Two-Ns merged 8 commits intotemporalio:mainfrom Mar 10, 2026
Merged
Conversation
|
|
||
| # Use these variables to force specific version of CLI/Time Skipping Server for SDK tests | ||
| # TESTS_CLI_VERSION: 'v0.13.2' | ||
| TESTS_CLI_VERSION: 'v1.6.1-server-1.31.0-150.0' |
There was a problem hiding this comment.
Pinned CLI version may be accidentally committed
Medium Severity
TESTS_CLI_VERSION was previously commented out (the normal state, matching release.yml), but is now uncommented and pinned to a specific version. The comment above says "Use these variables to force specific version," implying this is an override mechanism, not a permanent setting. This pin affects all CI tests globally, not just the new Nexus timeout tests. If left in, it prevents CI from testing against newer CLI/server releases and may mask compatibility issues.
chris-olszewski
approved these changes
Feb 25, 2026
02c1a67 to
06e5160
Compare
06e5160 to
9eb0f94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Add more Nexus operation timeouts.
Note
Medium Risk
Touches Workflow/worker Nexus command plumbing and failure decoding, which can affect how production workflows observe operation failures; changes are bounded and covered by new integration tests.
Overview
Adds Nexus operation
scheduleToStartTimeoutandstartToCloseTimeoutoptions to the Workflow Nexus client/interceptor API and wires them through to thescheduleNexusOperationcommand.Fixes decoding of Nexus operation timeouts in
WorkflowCodecRunnerby reading thetimedOutfailure field (was incorrectly usingcancelled), and adds integration tests that assertSCHEDULE_TO_STARTandSTART_TO_CLOSEtimeouts surface asNexusOperationFailurecauses.CI is pinned to a newer
TESTS_CLI_VERSIONto support these timeout behaviors.Written by Cursor Bugbot for commit 9eb0f94. This will update automatically on new commits. Configure here.