Skip to content

Add more Nexus operation timeouts.#1942

Merged
Quinn-With-Two-Ns merged 8 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:NEXUS-167
Mar 10, 2026
Merged

Add more Nexus operation timeouts.#1942
Quinn-With-Two-Ns merged 8 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:NEXUS-167

Conversation

@Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Feb 18, 2026

Add more Nexus operation timeouts.


Note

Medium Risk
Touches Workflow/worker Nexus command plumbing and failure decoding, which can affect how production workflows observe operation failures; changes are bounded and covered by new integration tests.

Overview
Adds Nexus operation scheduleToStartTimeout and startToCloseTimeout options to the Workflow Nexus client/interceptor API and wires them through to the scheduleNexusOperation command.

Fixes decoding of Nexus operation timeouts in WorkflowCodecRunner by reading the timedOut failure field (was incorrectly using cancelled), and adds integration tests that assert SCHEDULE_TO_START and START_TO_CLOSE timeouts surface as NexusOperationFailure causes.

CI is pinned to a newer TESTS_CLI_VERSION to support these timeout behaviors.

Written by Cursor Bugbot for commit 9eb0f94. This will update automatically on new commits. Configure here.

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review February 18, 2026 17:19
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 18, 2026 17:19
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.


# Use these variables to force specific version of CLI/Time Skipping Server for SDK tests
# TESTS_CLI_VERSION: 'v0.13.2'
TESTS_CLI_VERSION: 'v1.6.1-server-1.31.0-150.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned CLI version may be accidentally committed

Medium Severity

TESTS_CLI_VERSION was previously commented out (the normal state, matching release.yml), but is now uncommented and pinned to a specific version. The comment above says "Use these variables to force specific version," implying this is an override mechanism, not a permanent setting. This pin affects all CI tests globally, not just the new Nexus timeout tests. If left in, it prevents CI from testing against newer CLI/server releases and may mask compatibility issues.

Fix in Cursor Fix in Web

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the NEXUS-167 branch 2 times, most recently from 02c1a67 to 06e5160 Compare March 10, 2026 16:39
@Quinn-With-Two-Ns Quinn-With-Two-Ns enabled auto-merge (squash) March 10, 2026 18:22
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 84fe5fb into temporalio:main Mar 10, 2026
49 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants