Open
Conversation
Update the sdk-core submodule and adapt the TypeScript SDK to breaking
changes in the core API: replace RetryClient with Connection, update
error types (ClientInitError → ClientConnectError), wrap search
attributes in { indexedFields: ... }, and update codec runner and tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chris-olszewski
approved these changes
Mar 11, 2026
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Nothing is blocking on my end. Thanks for doing this.
| searchAttributes: | ||
| options.searchAttributes || options.typedSearchAttributes // eslint-disable-line @typescript-eslint/no-deprecated | ||
| ? encodeUnifiedSearchAttributes(options.searchAttributes, options.typedSearchAttributes) // eslint-disable-line @typescript-eslint/no-deprecated | ||
| ? { indexedFields: encodeUnifiedSearchAttributes(options.searchAttributes, options.typedSearchAttributes) } // eslint-disable-line @typescript-eslint/no-deprecated |
Member
There was a problem hiding this comment.
Note to self: now all calls of encodeUnifiedSearchAttributes have the form of { indexedFields: encodeUnifiedSearchAttributes(...) }. It might make sense to move this into the encoding function
Co-authored-by: Chris Olszewski <chris.olszewski@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Update the sdk-core submodule and adapt the TypeScript SDK to breaking changes in the core API: replace RetryClient with Connection, update error types (ClientInitError → ClientConnectError), wrap search attributes in { indexedFields: ... }, and update codec runner and tests.
Why?
Upcoming changes changes to Nexus error serialization requires a newer version of core.
Checklist
Existing tests run.