Add system Nexus signalWithStartWorkflow API#2127

Open

tconley1428 wants to merge 20 commits into

mainfrom

nexus-api-gen-signal-with-start

tconley1428 commented Jun 16, 2026

Contributor

Summary

add system Nexus TypeScript generation to build:protos using nex-gen
expose generated signalWithStartWorkflow workflow API and checked-in generated review output
serialize system Nexus envelopes with default JSON through the isolate, then protobuf-binary in the worker while applying codecs only to nested payloads
add unit and integration coverage for codec/payload converter behavior

Validation

NEX_GEN_BIN=../nexus-api-gen/target/debug/nex-gen pnpm run build:protos
pnpm --filter @temporalio/test run build:ts
pnpm -C packages/test exec ava ./lib/test-workflow-codec-runner.js
pnpm -C packages/test exec ava ./lib/test-system-nexus.js

Notes

Draft while the corresponding nex-gen TypeScript export/metadata changes are finalized and published.

tconley1428 force-pushed the nexus-api-gen-signal-with-start branch from 8e24cfd to da9a5ac Compare

June 16, 2026 21:03

tconley1428 mentioned this pull request

Adjust TypeScript generated exports temporalio/nex-gen#45

Merged

tconley1428 commented

View reviewed changes

scripts/gen-system-nexus.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-visitor.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-visitor.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-visitor.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts Outdated

tconley1428 commented

View reviewed changes

.github/workflows/ci.yml

chris-olszewski reviewed

View reviewed changes

scripts/gen-system-nexus.ts Outdated

scripts/gen-system-nexus.ts Outdated

packages/workflow/package.json Outdated

scripts/gen-system-nexus.ts

packages/workflow/system-nexus/typescript/temporal_model_converters.ts Outdated

scripts/gen-system-nexus.ts

tconley1428 added 5 commits

June 29, 2026 09:22


          Add system Nexus signal-with-start workflow API

b6124ae


          Improve system Nexus generated code validation

85d461b


          Address system Nexus generation review comments


          Update system Nexus proto path

8dbb53d


          Install nex-gen in generated code CI

aeb63ca

tconley1428 force-pushed the nexus-api-gen-signal-with-start branch from f5454fa to aeb63ca Compare

June 29, 2026 16:23

tconley1428 added 6 commits

June 29, 2026 09:26


          Fix lockfile after rebase

108486b


          Merge remote-tracking branch 'origin/main' into nexus-api-gen-signal-…

b825bcf

…with-start

# Conflicts:
#	pnpm-lock.yaml


          chore: use sdk-core system Nexus WIT

906001e


          fix: narrow system Nexus int64 helper

238821c


          fix: satisfy system Nexus lint

f5c320d


          fix: ignore generated system Nexus code in prune

49c74de

tconley1428 marked this pull request as ready for review

July 13, 2026 14:55

tconley1428 requested a review from a team as a code owner

July 13, 2026 14:55


          docs: add signalWithStartWorkflow changelog entry

chris-olszewski reviewed

View reviewed changes

chris-olszewski left a comment

Member

Dumping some minor package hygiene suggestions

.github/workflows/conventions.yml Outdated

packages/workflow/package.json

package.json

                   "lint": "eslint --no-error-on-unmatched-pattern --fix && prettier --write . && pnpm --recursive --stream run lint",
                   "lint:check": "eslint --no-error-on-unmatched-pattern && prettier --end-of-line auto --check .  && pnpm --recursive --stream run lint:check",
-                  "lint:prune": "ts-prune --error -p tsconfig.prune.json --ignore \"used in module\" --skip \".d.ts\"",
+                  "lint:prune": "ts-prune --error -p tsconfig.prune.json --ignore \"used in module|packages/workflow/src/nexus/system/generated\" --skip \".d.ts\"",

chris-olszewski Jul 13, 2026

Member

Note to self: verify dead code in workflow package isn't a significant increase

tconley1428 Jul 13, 2026

Contributor Author

It's mostly some proto converters that aren't necessarily used, it shouldn't be substantial.

package.json Outdated

tconley1428 added 2 commits

July 13, 2026 10:28


          chore: wire system Nexus generation into workflow build

fe6d637


          Merge remote-tracking branch 'origin/main' into nexus-api-gen-signal-…

7d2f7c4

…with-start

# Conflicts:
#	CHANGELOG.md


          chore: restore explicit system Nexus generation

9ca829e

chris-olszewski approved these changes

View reviewed changes

chris-olszewski left a comment

Member

2 questions and I do think we want to avoid using user configured payload converter for the search attributes

packages/worker/src/workflow-codec-runner.ts Outdated

packages/workflow/system-nexus/typescript/temporal_model_converters.ts Outdated

packages/worker/src/workflow-codec-runner.ts

tconley1428 and others added 5 commits

July 14, 2026 08:41


          fix system Nexus search attribute conversion

5e2a795


          refine workflow codec pending context helper

f6a9784


          Merge branch 'main' into nexus-api-gen-signal-with-start

3ad354d


          Merge remote-tracking branch 'origin/main' into nexus-api-gen-signal-…

6bccb30

…with-start

# Conflicts:
#	.github/workflows/conventions.yml
#	package.json


          Merge remote-tracking branch 'origin/nexus-api-gen-signal-with-start'…

aa46c96

… into nexus-api-gen-signal-with-start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet