fix(explorer): preserve unrelated propAMM output transfers - #1234
Open
Osraka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TradeExecutedrecipientRoot cause
The propAMM receipt composer identified output settlement transfers by pool, token, and amount.
TradeExecutedalso identifies the recipient, but that field was not part of the match. If the same transaction contained another pool transfer with the same token and amount to a different address, both transfers were marked as settlement activity and hidden from the receipt summary.Before / after
TradeExecuted.recipientNormal propAMM receipt rendering is unchanged, so there is no separate visual screenshot.
Testing
pnpm --filter explorer test --run test/known-events.test.ts(39 tests)pnpm --filter explorer test --run(17 files, 128 tests)pnpm --filter explorer check(Biome, typecheck, and 113 node tests)