Skip to content

fix(explorer): preserve unrelated propAMM output transfers - #1234

Open
Osraka wants to merge 1 commit into
tempoxyz:mainfrom
Osraka:fix/explorer-propamm-recipient-matching
Open

fix(explorer): preserve unrelated propAMM output transfers#1234
Osraka wants to merge 1 commit into
tempoxyz:mainfrom
Osraka:fix/explorer-propamm-recipient-matching

Conversation

@Osraka

@Osraka Osraka commented Sep 4, 2026

Copy link
Copy Markdown

Summary

  • Match propAMM output settlement transfers against the TradeExecuted recipient
  • Preserve unrelated pool transfers that happen to use the same token and amount
  • Extend the existing propAMM receipt test with the colliding-transfer case

Root cause

The propAMM receipt composer identified output settlement transfers by pool, token, and amount. TradeExecuted also identifies the recipient, but that field was not part of the match. If the same transaction contained another pool transfer with the same token and amount to a different address, both transfers were marked as settlement activity and hidden from the receipt summary.

Before / after

Scenario Before After
Pool sends the expected output to TradeExecuted.recipient Hidden as propAMM settlement Unchanged
Pool sends the same token and amount to another recipient Also hidden Preserved as a separate transfer

Normal propAMM receipt rendering is unchanged, so there is no separate visual screenshot.

Testing

  • pnpm --filter explorer test --run test/known-events.test.ts (39 tests)
  • pnpm --filter explorer test --run (17 files, 128 tests)
  • pnpm --filter explorer check (Biome, typecheck, and 113 node tests)
  • Pre-commit hooks on the two changed files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant