[WIP] fix(specs): change escrow rounding behavior to match Rust implementation #1827
+236
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrobinson
requested review from
0xKitsune,
howydev and
legion2002
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danrobinson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the quote token rounding behavior in escrow calculation (when a maker is placing or canceling a bid) in the reference implementation to match the Rust implementation (which was changed in #1583).
This is separate from #1823 and #1824 but might interact with them. It also already causes a few tests to fail; will need to sort that out.