fix: validate calls inside handler #1845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1844
Problem
The
TempoTransaction::validate()function checks important transaction structure rules (e.g., CREATE must be first call, no CREATE with authorization list), but this validation was only performed during RLP decoding. Transactions constructed programmatically or through other paths could bypass these checks before execution.In this PR we add the validation for the batch calls inside the handler.