add validate_core_asset fn #28
Conversation
| let (mut royalties, collection) = | ||
| if let UpdateAuthority::Collection(asset_collection) = asset.update_authority { | ||
| // Collection account must be provided. | ||
| if maybe_collection_info.is_none() { |
There was a problem hiding this comment.
Nit: could be cleaner with a match on maybe_collection_info
| royalty_fee_bps, | ||
| royalty_enforced: true, | ||
| }) | ||
| } |
There was a problem hiding this comment.
So this will replace validate_asset right? If so, remember to remove validate_asset from all uses + toolbox goforward.
There was a problem hiding this comment.
Yeah, I've removed it from toolbox now and have it removed from AMM in an open PR.
| royalty_enforced: true, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
Is the biggest difference that this now:
- Validates
maybe_collection_infoalways - Extracts
whitelist_creators+royalty_fee_bps
There was a problem hiding this comment.
The main differences are 1) it fetches the verified creators plugin in addition to royalties and 2) returns the data more generically so it can be used for both royalty and whitelist validation purposes.
The checks are the same:
- asset is owned by mpl-core
- asset is valid AssetV1
- if collection is passed in it's owned by mpl-core and is a valid CollectionV1
- collection on the asset, must match passed in collection, if present on the asset
I'll add more explicit account type checks for good measure.
No description provided.