Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

feat: support follow the k8s log #131

Merged
merged 2 commits into from
Aug 8, 2023
Merged

feat: support follow the k8s log #131

merged 2 commits into from
Aug 8, 2023

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Aug 7, 2023

This PR adds the mdz logs <name> --follow argument.

@kemingy kemingy marked this pull request as ready for review August 8, 2023 07:58
@kemingy kemingy requested a review from gaocegege August 8, 2023 07:58
@kemingy
Copy link
Member Author

kemingy commented Aug 8, 2023

The stream log has a delay of about 70s. cc @gaocegege

@gaocegege
Copy link
Member

The stream log has a delay of about 70s. cc @gaocegege

Where does it come from?

@kemingy
Copy link
Member Author

kemingy commented Aug 8, 2023

The stream log has a delay of about 70s. cc @gaocegege

Where does it come from?

I have no idea. I suspect it's because the log is retrieved after some delay. Not familiar with Kubernetes logs.

@kemingy
Copy link
Member Author

kemingy commented Aug 8, 2023

Shall we merge this PR and track it in another issue?

@gaocegege
Copy link
Member

SGTM!

@gaocegege gaocegege merged commit c23067f into main Aug 8, 2023
3 checks passed
@gaocegege gaocegege deleted the follow branch August 8, 2023 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support --follow options in mdz logs command
2 participants