This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
feat: Support volume #194
Open
feat: Support volume #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
Signed-off-by: xieydd <[email protected]>
|
PTAL @xieydd @gaocegege @kemingy |
xieydd
requested review from
gaocegege,
kemingy and
cutecutecat
and removed request for
gaocegege
kemingy
reviewed
Nov 4, 2023
| if len(function.Spec.Volumes) > 0 { | ||
| for _, volume := range function.Spec.Volumes { | ||
| if (volume.Type == v2alpha1.VolumeTypeLocal) && (len(volume.NodeNames) == 0) { | ||
| // no need create pv and pvc for hostPath |
There was a problem hiding this comment.
Suggested change
| // no need create pv and pvc for hostPath | |
| // no need delete pv and pvc for hostPath |
| switch volume.Type { | ||
| case v2alpha1.VolumeTypeGCSFuse: | ||
| pv.Spec.Capacity = corev1.ResourceList{ | ||
| corev1.ResourceStorage: resource.MustParse(capacity), |
cutecutecat
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.