This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
feat(mdz deploy): Make watch by default by polling for instance status after InferenceCreate #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teddy Xinyuan Chen <[email protected]>
|
CI failed on test of |
|
You did not import it. |
|
See #137 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55 .
This PR introduces a new --detach flag to the mdz deploy command and implements a readiness check for deployments. If the --detach flag is not provided (default behavior), the deploy command will block and poll the deployment status until it's ready or a timeout is reached.
The readiness check involves polling the status of the deployment instances until they reach the 'Running' state, with a default polling interval of 3 seconds, and a timeout of 300 seconds. Both these values are now parameterized and can be adjusted as per the requirements.