Skip to content

Add equalize #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 29, 2020
Merged

Add equalize #1413

merged 17 commits into from
Mar 29, 2020

Conversation

abhichou4
Copy link
Contributor

Refers to #1333

Abhineet Choudhary added 2 commits March 26, 2020 03:52
@Squadrick
Copy link
Member

@abhichou4 Can you fix the merge conflicts?

Squadrick
Squadrick suggested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, a few more stylistic changes.

Squadrick
Squadrick suggested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes.

@abhichou4 abhichou4 requested a review from Squadrick March 27, 2020 04:54
@abhichou4 abhichou4 mentioned this pull request Mar 27, 2020
Merged
Squadrick
Squadrick suggested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, you need to add a test with channels_first.

@abhichou4
Copy link
Contributor Author

cc @Squadrick

Squadrick
Squadrick approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Squadrick Squadrick merged commit 3fc1bad into tensorflow:master Mar 29, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Add equalize image op (tensorflow#1413)
22052e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Squadrick Squadrick Squadrick approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

Assignees
No one assigned
Labels
cla: yes github image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhichou4 @Squadrick @googlebot