Skip to content

add dtypes to blend #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2020
Merged

add dtypes to blend #1453

merged 4 commits into from
Mar 29, 2020
+28 −16

Conversation

abhichou4
Copy link
Contributor

@abhichou4 abhichou4 commented Mar 27, 2020 •
edited
Loading

Small change so operations using blend don't have to cast their results to tf.uint8 before using it. (#1452)

@boring-cyborg boring-cyborg bot added the image label Mar 27, 2020
@abhichou4
Copy link
Contributor Author

@gabrieldemarmiesse everything handled in tf.float32 now and it's also the return dtype. Any thoughts?

Squadrick
Squadrick approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Squadrick
Squadrick suggested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, just a small change.

Squadrick
Squadrick approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Squadrick Squadrick merged commit caf2a65 into tensorflow:master Mar 29, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Add more dtypes support to blend op (tensorflow#1453)
3dfad07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Squadrick Squadrick Squadrick approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

Assignees
No one assigned
Labels
cla: yes image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhichou4 @Squadrick @googlebot