-
Notifications
You must be signed in to change notification settings - Fork 632
TF2.16 support: hermetic python shim, TF 2.16.2 pin, legacy Keras path, setup/packaging fixes #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
TF2.16 support: hermetic python shim, TF 2.16.2 pin, legacy Keras path, setup/packaging fixes #913
Conversation
mhucka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work, and I'm sorry about the number of changes requested here …
Co-authored-by: Michael Hucka <[email protected]>
Co-authored-by: Michael Hucka <[email protected]>
Co-authored-by: Michael Hucka <[email protected]>
Co-authored-by: Michael Hucka <[email protected]>
Co-authored-by: Michael Hucka <[email protected]>
Co-authored-by: Michael Hucka <[email protected]>
Co-authored-by: Michael Hucka <[email protected]>
|
About the version used here (0.7.5): I put 0.7.5 because in the master branch in releases/setup.py: Line 58 in c6a90ac
It was 0.7.4 As you mentioned the current version on PyPi is 0.7.3... I could patch releases/setup.py and tensorflow_quantum/init.py to match 0.7.4 (init has 0.7.2): quantum/tensorflow_quantum/__init__.py Line 67 in c6a90ac
And maybe this new version could be the tag 0.7.4 right? Or maybe the current version that is in master is the unofficial version 0.7.4 and I should update it to 0.7.5? (to avoid losing 0.7.4 that is in master). |
I know we discussed this offline, but just to follow up here too for future reference: The 0.7.4 in main is intended to be the next version. I'm not sure if this convention is different from what TensorFlow does, but the convention for TFQ has been that For TFQ, since the last release was for 0.7.3, the version was bumped in main to 0.7.4 after the release, and no releases have happened since that one. So the next release is 0.7.4. Based on the PR the version number was bumped to 0.7.4 after the last release, it looks like the version number was updated to 0.7.4 only in At some point in the future, I think we should change the numbering scheme to include |
Summary
Key changes
--python=flag; generate .tf_configure.bazelrc + .bazelrc + the python shim${PYTHON_BIN_PATH:-python3}and ensure setuptools presentTesting
bazel build ... release:build_pip_packagesucceedsNotes