Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ISSUE_TEMPLATE.md #16635

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Update ISSUE_TEMPLATE.md #16635

merged 1 commit into from
Feb 1, 2018

Conversation

MarkDaoust
Copy link
Member

Fixes 16350

@andrewharp andrewharp merged commit 970efe5 into master Feb 1, 2018
@aselle
Copy link
Contributor

aselle commented Feb 8, 2018

Thanks for this PR. Note: use you need to say Fixes #16350, for this auto closing to work. Also, it needs to be done to models as well (I'm doing that now)

@aselle aselle mentioned this pull request Feb 8, 2018
Closed
@gunan gunan deleted the MarkDaoust-patch-1-1 branch February 10, 2018 17:52
copybara-service bot pushed a commit that referenced this pull request Sep 4, 2024
@sergachev @tensorflower-gardener
PR #16635: [GPU][NFC] Cleanup handling of determinism flags.
eb84298 
Imported from GitHub PR openxla/xla#16635

dynamic_slice_fusion_test does not need to disable autotuning which set_xla_gpu_deterministic_ops does, therefore should use xla_gpu_exclude_nondeterministic_ops.
Copybara import of the project:

--
0beaf66fceae6079c644ec69be2287bfbc03da91 by Ilia Sergachev <[email protected]>:

[GPU][NFC] Cleanup handling of determinism flags.

Merging this change closes #16635

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#16635 from openxla:cleanup_determinism 0beaf66fceae6079c644ec69be2287bfbc03da91
PiperOrigin-RevId: 670758139
@copybara-service copybara-service bot mentioned this pull request Sep 4, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Sep 4, 2024
@sergachev @tensorflower-gardener
PR #16635: [GPU][NFC] Cleanup handling of determinism flags.
f5a20b6 
Imported from GitHub PR openxla/xla#16635

dynamic_slice_fusion_test does not need to disable autotuning which set_xla_gpu_deterministic_ops does, therefore should use xla_gpu_exclude_nondeterministic_ops.
Copybara import of the project:

--
0beaf66fceae6079c644ec69be2287bfbc03da91 by Ilia Sergachev <[email protected]>:

[GPU][NFC] Cleanup handling of determinism flags.

Merging this change closes #16635

PiperOrigin-RevId: 670863229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewharp andrewharp andrewharp approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarkDaoust @aselle @andrewharp @googlebot