Skip to content

Fix non-unique /tmp filenames in external library download scripts #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

Fix non-unique /tmp filenames in external library download scripts #3182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e2528a
Fix non-unique /tmp filenames in external library download scripts
ilya-kupchenko Aug 22, 2025
b80034b
Merge remote-tracking branch 'upstream/main' into bugfix/issue-3042-t…
ilya-kupchenko Sep 1, 2025
75b7421
Use mktemp for safer temporary directory creation
ilya-kupchenko Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions tensorflow/lite/micro/tools/make/ext_libs/cmsis_download.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,28 +48,34 @@ if [ -d ${DOWNLOADED_CMSIS_PATH} ]; then
echo >&2 "${DOWNLOADED_CMSIS_PATH} already exists, skipping the download."
else

# Create a temporary directory with the unique name for better isolation
TEMP_DIR=$(mktemp -d /tmp/$(basename $0 .sh).XXXXXX)

# Set up cleanup trap for all exit conditions
trap 'rm -rf "${TEMP_DIR}"' EXIT INT TERM

ZIP_PREFIX="5782d6f8057906d360f4b95ec08a2354afe5c9b9"
CMSIS_URL="http://github.com/ARM-software/CMSIS_6/archive/${ZIP_PREFIX}.zip"
CMSIS_MD5="563e7c6465f63bdc034359e9b536b366"

# wget is much faster than git clone of the entire repo. So we wget a specific
# version and can then apply a patch, as needed.
wget ${CMSIS_URL} -O /tmp/${ZIP_PREFIX}.zip >&2
check_md5 /tmp/${ZIP_PREFIX}.zip ${CMSIS_MD5}
wget ${CMSIS_URL} -O ${TEMP_DIR}/${ZIP_PREFIX}.zip >&2
check_md5 ${TEMP_DIR}/${ZIP_PREFIX}.zip ${CMSIS_MD5}

unzip -qo /tmp/${ZIP_PREFIX}.zip -d /tmp >&2
mv /tmp/CMSIS_6-${ZIP_PREFIX} ${DOWNLOADED_CMSIS_PATH}
unzip -qo ${TEMP_DIR}/${ZIP_PREFIX}.zip -d ${TEMP_DIR} >&2
mv ${TEMP_DIR}/CMSIS_6-${ZIP_PREFIX} ${DOWNLOADED_CMSIS_PATH}

# Also pull the related CMSIS Cortex_DFP component for generic Arm Cortex-M device support
ZIP_PREFIX="c2c70a97a20fb355815e2ead3d4a40e35a4a3cdf"
CMSIS_DFP_URL="http://github.com/ARM-software/Cortex_DFP/archive/${ZIP_PREFIX}.zip"
CMSIS_DFP_MD5="3cbb6955b6d093a2fe078ef2341f6b89"

wget ${CMSIS_DFP_URL} -O /tmp/${ZIP_PREFIX}.zip >&2
check_md5 /tmp/${ZIP_PREFIX}.zip ${CMSIS_DFP_MD5}
wget ${CMSIS_DFP_URL} -O ${TEMP_DIR}/${ZIP_PREFIX}.zip >&2
check_md5 ${TEMP_DIR}/${ZIP_PREFIX}.zip ${CMSIS_DFP_MD5}

unzip -qo /tmp/${ZIP_PREFIX}.zip -d /tmp >&2
mv /tmp/Cortex_DFP-${ZIP_PREFIX} ${DOWNLOADED_CORTEX_DFP_PATH}
unzip -qo ${TEMP_DIR}/${ZIP_PREFIX}.zip -d ${TEMP_DIR} >&2
mv ${TEMP_DIR}/Cortex_DFP-${ZIP_PREFIX} ${DOWNLOADED_CORTEX_DFP_PATH}

fi

Expand Down
15 changes: 11 additions & 4 deletions tensorflow/lite/micro/tools/make/ext_libs/cmsis_nn_download.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,20 @@ elif [ ! -d ${DOWNLOADS_DIR} ]; then
elif [ -d ${DOWNLOADED_CMSIS_NN_PATH} ]; then
echo >&2 "${DOWNLOADED_CMSIS_NN_PATH} already exists, skipping the download."
else

# Create a temporary directory with the unique name for better isolation
TEMP_DIR=$(mktemp -d /tmp/$(basename $0 .sh).XXXXXX)

# Set up cleanup trap for all exit conditions
trap 'rm -rf "${TEMP_DIR}"' EXIT INT TERM

# wget is much faster than git clone of the entire repo. So we wget a specific
# version and can then apply a patch, as needed.
wget ${CMSIS_NN_URL} -O /tmp/${ZIP_PREFIX_NN}.zip >&2
check_md5 /tmp/${ZIP_PREFIX_NN}.zip ${CMSIS_NN_MD5}
wget ${CMSIS_NN_URL} -O ${TEMP_DIR}/${ZIP_PREFIX_NN}.zip >&2
check_md5 ${TEMP_DIR}/${ZIP_PREFIX_NN}.zip ${CMSIS_NN_MD5}

unzip -qo /tmp/${ZIP_PREFIX_NN}.zip -d /tmp >&2
mv /tmp/CMSIS-NN-${ZIP_PREFIX_NN} ${DOWNLOADED_CMSIS_NN_PATH}
unzip -qo ${TEMP_DIR}/${ZIP_PREFIX_NN}.zip -d ${TEMP_DIR} >&2
mv ${TEMP_DIR}/CMSIS-NN-${ZIP_PREFIX_NN} ${DOWNLOADED_CMSIS_NN_PATH}
fi

echo "SUCCESS"
16 changes: 11 additions & 5 deletions tensorflow/lite/micro/tools/make/ext_libs/eyalroz_printf_download.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,23 @@ if [ -d ${DOWNLOADED_PRINTF_PATH} ]; then
echo >&2 "${DOWNLOADED_PRINTF_PATH} already exists, skipping the download."
else

# Create a temporary directory with the unique name for better isolation
TEMP_DIR=$(mktemp -d /tmp/$(basename $0 .sh).XXXXXX)

# Set up cleanup trap for all exit conditions
trap 'rm -rf "${TEMP_DIR}"' EXIT INT TERM

ZIP_PREFIX="f8ed5a9bd9fa8384430973465e94aa14c925872d"
PRINTF_URL="https://github.com/eyalroz/printf/archive/${ZIP_PREFIX}.zip"
PRINTF_MD5="5772534c1d6f718301bca1fefaba28f3"

# wget is much faster than git clone of the entire repo. So we wget a specific
# version and can then apply a patch, as needed.
wget ${PRINTF_URL} -O /tmp/${ZIP_PREFIX}.zip >&2
check_md5 /tmp/${ZIP_PREFIX}.zip ${PRINTF_MD5}
wget ${PRINTF_URL} -O ${TEMP_DIR}/${ZIP_PREFIX}.zip >&2
check_md5 ${TEMP_DIR}/${ZIP_PREFIX}.zip ${PRINTF_MD5}

unzip -qo /tmp/${ZIP_PREFIX}.zip -d /tmp >&2
mv /tmp/printf-${ZIP_PREFIX} ${DOWNLOADED_PRINTF_PATH}
unzip -qo ${TEMP_DIR}/${ZIP_PREFIX}.zip -d ${TEMP_DIR} >&2
mv ${TEMP_DIR}/printf-${ZIP_PREFIX} ${DOWNLOADED_PRINTF_PATH}
fi

echo "SUCCESS"
echo "SUCCESS"
Loading