yield before wait/reserve and support for matrix multiplication #96
Conversation
FConstantinos
force-pushed
the
kostas/AST
branch
from
e20d9b9 to
8f18e74
Compare
test/sim/test_program.py
Outdated
| tt_testing.assert_close(out, expected) | ||
|
|
||
| def test_modes_produce_same_result(self) -> None: | ||
| """Test that THREADED mode works (COOPERATIVE skipped due to getsource issues).""" |
There was a problem hiding this comment.
What's the getsource issue?
There was a problem hiding this comment.
ah, just some issue I had while working on this, fixed now to run on both modes
python/sim/decorators.py
Outdated
| def decorator(func: FunctionType) -> BindableTemplate: | ||
| class ComputeTemplate: | ||
| __name__ = func.__name__ | ||
| _func = func # Store original function for inspect.getsource() |
There was a problem hiding this comment.
Consider using __wrapped__ instead of _func here. It's the standard convention from functools.wraps and has built-in support via inspect.unwrap() which would simplify the cooperative mode code to just inspect.unwrap(func) instead of manually accessing _func. Also means tools like debuggers and other decorators automatically understand the wrapping chain.
There was a problem hiding this comment.
Maybe this is the issue I commented on earlier regarding getsource?
There was a problem hiding this comment.
yes, exactly! Thanks, I fixed it now :)
FConstantinos
changed the title
| 1 if i < remainder_tiles else 0 | ||
| ) | ||
| core_work.append((start_tile_id, num_tiles_this_core)) | ||
| start_tile_id += num_tiles_this_core |
There was a problem hiding this comment.
After #67 goes in this will be available in our repo with no dependencies
zoecarver
left a comment
zoecarver
left a comment
There was a problem hiding this comment.
Do we have some simulator documentation? Might be nice to document the new execution modes outside of the code. This looks good to me!
| @ttl.compute() | ||
| def mm_compute(): | ||
| # Compute each output tile (m, n). | ||
| for m in range(Mt): |
| b_block = b_cb.wait() # blocking | ||
|
|
||
| if k == 0: | ||
| # Initialize output tile |
There was a problem hiding this comment.
shouldn't need initialization/first iteration logic here
| b_block = b_cb.wait() # blocking | ||
|
|
||
| if k == 0: | ||
| # Initialize output tile. |
There was a problem hiding this comment.
same thing, shouldn't need first iteration logic
There was a problem hiding this comment.
This turns out to be a rather involved change and I'd prefer to fix it in another PR. In the meantime I've created an issue for this:
I've created a new ticket for that: |
Uh oh!
There was an error while loading. Please reload this page.