Skip to content

Conversation

@VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Jan 7, 2026

Ticket

tenstorrent/tt-metal#27433 , tenstorrent/tt-metal#34061

Problem description

From here, exp+fast+approx is better compared to exp+approx .

What's changed

Image
  • Removed fast_and_approx flag as exp+approx is to be removed
  • Created seperate init function specific to exp+approx(piecewise) that could be used for sdpa and other ops using the same
  • init_exponential_sdpa_first_column is created specific for sdpa based on algorithm

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Thank you for your contribution! 🚀
If you want to run metal post-commit tests, you can add the metal-post-commit-tests label to this pull request.
📖 For more information, please refer to our CONTRIBUTING guide.

@fvranicTT
Copy link
Contributor

fvranicTT commented Jan 8, 2026

Could you:

  1. fix pre-commit issues (C++ code formatting)
  2. create a branch in metal, fix the API breaking changes and run tests to make sure nothing remains broken.
  3. link the metal PR here?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants