Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the reverted PR for Optimize the web demo for yolov4 (#15478) #15838

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

dvartaniansTT
Copy link
Contributor

@dvartaniansTT dvartaniansTT commented Dec 9, 2024

Problem description

Have a real-time web demo for yolov4.
There was a merged PR for this that got reverted due to some failure. redoing the PR and running more tests for it now.

What's changed

Enable trace + 2cq
Optimize the post processing

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

### Problem description
Have a real-time web demo for yolov4

### What's changed
Enable trace + 2cq
Optimize the post processing 

### Checklist
- [x] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [x] New/Existing tests provide coverage for changes

---------

Co-authored-by: Mohamed Bahnas <[email protected]>
Co-authored-by: Mohamed Bahnas <[email protected]>
Copy link
Contributor

@shwetankTT shwetankTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dvartaniansTT
Copy link
Contributor Author

@mbahnasTT mbahnasTT requested a review from a team as a code owner January 14, 2025 06:50
Copy link
Contributor

@pavlejosipovic pavlejosipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the idea behind having test_ttnn_yolov4.py and test_ttnn_yolov4_orig.py ?

@shwetankTT shwetankTT self-requested a review January 14, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants