-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the reverted PR for Optimize the web demo for yolov4 (#15478) #15838
Open
dvartaniansTT
wants to merge
50
commits into
main
Choose a base branch
from
dvartanians/fix_yolov4_faster_webdemo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Problem description Have a real-time web demo for yolov4 ### What's changed Enable trace + 2cq Optimize the post processing ### Checklist - [x] Post commit CI passes - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [x] New/Existing tests provide coverage for changes --------- Co-authored-by: Mohamed Bahnas <[email protected]> Co-authored-by: Mohamed Bahnas <[email protected]>
shwetankTT
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
shwetankTT
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the idea behind having test_ttnn_yolov4.py and test_ttnn_yolov4_orig.py ?
mbahnasTT
approved these changes
Feb 19, 2025
bbradelTT
approved these changes
Feb 19, 2025
ayerofieiev-tt
approved these changes
Feb 19, 2025
TT-BrianLiu
requested changes
Feb 19, 2025
tests/ttnn/integration_tests/yolov4/test_ttnn_post_processing.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Have a real-time web demo for yolov4.
There was a merged PR for this that got reverted due to some failure. redoing the PR and running more tests for it now.
What's changed
Enable trace + 2cq
Optimize the post processing
Checklist