Xuncai/all gather fixes #17155
Merged
Xuncai/all gather fixes #17155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caixunshiren
requested review from
SeanNijjar,
jvegaTT and
tt-aho
as code owners
caixunshiren
force-pushed
the
xuncai/all-gather-fixes
branch
from
dfc4c8b to
e5564d4
Compare
SeanNijjar
approved these changes
Jan 30, 2025
I think it would be better if I add the test along with my CCL minimal pr? So that these specific CCL shapes can be added. |
nikileshx
pushed a commit
to nikileshx/tt-metal
that referenced
this pull request
Feb 3, 2025
### Ticket This PR fixes two issues exposed when integrating ccl async to TG llama: - Program caching does not handle input tensor specs properly - All gather does not handle subdevice properly ### Checklist - [x] Post commit CI passes: https://github.com/tenstorrent/tt-metal/actions/runs/13059537328 - [x] TG Nightly: https://github.com/tenstorrent/tt-metal/actions/runs/13059546044 - [x] TG unit frequent: https://github.com/tenstorrent/tt-metal/actions/runs/13059554924 - [x] T3K: https://github.com/tenstorrent/tt-metal/actions/runs/13059564134 --------- Co-authored-by: avoraTT <[email protected]>
hschoi4448
pushed a commit
that referenced
this pull request
Feb 20, 2025
### Ticket This PR fixes two issues exposed when integrating ccl async to TG llama: - Program caching does not handle input tensor specs properly - All gather does not handle subdevice properly ### Checklist - [x] Post commit CI passes: https://github.com/tenstorrent/tt-metal/actions/runs/13059537328 - [x] TG Nightly: https://github.com/tenstorrent/tt-metal/actions/runs/13059546044 - [x] TG unit frequent: https://github.com/tenstorrent/tt-metal/actions/runs/13059554924 - [x] T3K: https://github.com/tenstorrent/tt-metal/actions/runs/13059564134 --------- Co-authored-by: avoraTT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
This PR fixes two issues exposed when integrating ccl async to TG llama:
Checklist