Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Test code updates and minor fixes #17570

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

aagarwalTT
Copy link
Contributor

@aagarwalTT aagarwalTT commented Feb 4, 2025

Ticket

Link to Github Issue

Problem description

The test code selects worker cores at random for running traffic b/w chips. This could impact benchmarking as the performance could be impacted by the physical distance of the cores from the routers.

What's changed

  • The test code will now consistently pick the optimum worker cores for any given router. This will minimize any variations in the performance numbers because of worker core selection.
  • New options:
    • Benchmark mode (--benchmark): Bundles together all the settings and configurations needed to run perf benchmarks.
    • Packet size in KB (--packet_size_kb)
  • Removed options:
    • Max packet size in words (--max_packet_size_words): Use --packet_size_kb instead.

Checklist

@aagarwalTT aagarwalTT merged commit b981271 into main Feb 5, 2025
222 of 224 checks passed
@aagarwalTT aagarwalTT deleted the aagarwal/test-upgrades branch February 5, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants