upsize EDM fabric channel buffer slots to be able to fit 4 bfp8 tiles per packet #18000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-aho
approved these changes
Feb 19, 2025
hschoi4448
pushed a commit
that referenced
this pull request
Feb 20, 2025
… per packet (#18000) The current default EDM buffer slot size is 4096 which can only store 3 bfp8 tiles. There is enough space in erisc L1 unreserved space such that all channels can have a power of 2 buffer slot count and also have a slot size of 4 bfp8 tiles. There is inefficient space for 5 bfp8 tiles per slot. This commit bumps up the buffer slot size to fit 4 bfp8 tiles per packet, which is preferable for workloads with bfp8 tiles sent over fabric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#17423
Problem description
The current default EDM buffer slot size is 4096 which can only store 3 bfp8 tiles. There is enough space in erisc L1 unreserved space such that all channels can have a power of 2 buffer slot count and also have a slot size of 4 bfp8 tiles. There is inefficient space for 5 bfp8 tiles per slot.
What's changed
This PR bumps up the buffer slot size to fit 4 bfp8 tiles per packet, which is preferable for workloads with bfp8 tiles sent over fabric.
Checklist