forked from sidekiq/sidekiq
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci redis 7 0 #1
Closed
Closed
Ci redis 7 0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the example config to use default values for most things (like concurrency) and provide examples of how to customize. It also includes some of the Rails default job queues for a more complete example.
* Add iteration support for long-running jobs * Address feedback * Assign lifecycle in the correct place
* New registration API for web extensions * Add helper methods to generate proper css/script tags * Adjust register API based on feedback * update readme * changes * further polish * remove puts
…aises an error that is then retried successfully (sidekiq#6302)
Ensure CurrentAttributes are restored to their original values, rather than cleared. Fixes sidekiq#6306
redis-client v0.22.2 automatically adds `read_timeout` to the socket read timeout, so we no longer need to manually add this. Prior this commit, the total socket read timeout crept up to 8 seconds: ``` conn.read_timeout + conn.read_timeout + TIMEOUT = 3 + 3 + 2 = 8 ``` Now it is 5 seconds: ``` conn.read_timeout + TIMEOUT = 3 + 2 = 5 ``` This relates to sidekiq#6162.
Sidekiq uses this and it's getting the same treatment like `base64`, `mutex_m`, etc. Starting in Ruby 3.4 a warning will be emitted, and Ruby 3.5 will error
* iteration polish * this was promoted to sidekiq::job * Add S::IterableJob module with basic rdoc * Feedback * Always use monotime if only performing relative time calcs * namespace internal state to avoid instance variable name collisions * Verify job stopping * more useful change note * Fix invalid size * Add cleanup to remove data upon success, should iteration_key be public... * Adjust iteration to avoid duplicate cursor, remove nested iterator support * Add simple iterable jobs for integration testing * Use scheduling via middleware rather than retries for interruption restarts. We don't want to see backtraces in the logs for interruptions. * get sqlite working * Rename on_shutdown to on_stop, this isn't a process shutdown callback * Shrink variable names to reduce data size in Redis * adjust processor logic to cleanly handle job interrupts
…o second histo bucket
…#interrupted?, less likely to collide with user APIs
* wip: multi-day metrics storage * feat(metrics): Add UI support for multi-day query and view * feat(metrics): DoS sanity check, add hours query testing * Fixes & improvements to multi-day metrics (sidekiq#6620) * Fix period selector on histogram/bubble metrics page * Include month & day labels on the chart when viewing more than one day * Don't show a time range in the chart tooltip, it's confusing * Time buckets for marks need to be rounded the same as other data points * Series are internally represented as ISO8601 timestamps * Convert metrics overview and bubble chart to time series * Buckets are no longer needed with time series chart * constrain metrics_for_job bounds to 8h max * Add rake task to seed 72 hours of random metric data * Fix dark grid lines, sidekiq#6614 * feat: add auto-refresh to 1h metrics page. * fix: lower-case for header keys, per Rack --------- Co-authored-by: Adam McCrea <[email protected]>
* Add dragonfly version tags to CI Dragonfly does publish tags to docker builds: dragonflydb/dragonfly#3233 Add the minimum supported version to CI - `1.13+` as per README. * Update minimum supported dragonfly version to 1.26 * CI fails with 1.26 - bump to 1.27 Also update README accordingly. --------- Co-authored-by: Tejas Bubane <[email protected]>
…nes elements vertically aligned more often.
…o require ordering
…liance to require ordering" This reverts commit 76113e0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.