Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A tracking-on finger tap authorizes one soft-keyboard request if a cursor-enabled screen update follows within3000ms. No new escape sequence, stored MotionEvent, polling timer, or keyboard popups from unarmed cursor animation. This focused patch is independent of the two mouse-gesture PRs#5420/#5421.
Owner path
TerminalViewauthorizes only its existing quick finger-tap branch, before emitting LEFT press/release. Physical mouse, finger scroll and recognizer-suppressed long press do not enter it.onScreenUpdatedconsumes the authorization before requesting IME, reading only the view's current emulator and DECTCEM (isCursorEnabled), not the local blink animation phase.TerminalViewClient.onRequestSoftKeyboardhas a concrete default no-op for non-IME clients. The actual app implements the existing disable-flags/KeyboardUtils.showSoftKeyboard path, shared with its old tracking-off tap handler. URL processing is not rerun and keyboard preferences remain authoritative.Automatic hide is deliberately not added: cursor hiding during rendering must not repeatedly dismiss a keyboard. A later tap may request the keyboard even when the focused application's cursor is already enabled.
Verification
git diff --checkpasses.Counterpart and limits
A TUI must show its terminal cursor while text entry has focus. Textual's cursor-focus counterpart is separately maintained; no Textual/Toad dependency or application-name special case is added here. SSH/mosh/device acceptance remains outstanding. The current tester uses Google Play Termux; no compatibility of its installed signer with this fork's public GitHub test key is assumed. No uninstall, forced downgrade, app-ID workaround or data loss is authorized.