Fix shell metacharacter injection in file-drop path quoting#37
Merged
lassejlv merged 2 commits intopaste-featurefrom Feb 22, 2026
Merged
Fix shell metacharacter injection in file-drop path quoting#37lassejlv merged 2 commits intopaste-featurefrom
lassejlv merged 2 commits intopaste-featurefrom
Conversation
Co-authored-by: lassejlv <77295879+lassejlv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for bracketed paste and file drag-and-drop
Fix shell metacharacter injection in file-drop path quoting
Feb 22, 2026
lassejlv
requested changes
Feb 22, 2026
Member
lassejlv
left a comment
There was a problem hiding this comment.
Check an extra time if its good enough
Contributor
Author
Checked again — everything looks good:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
handle_file_droppath-quoting logic only triggered for paths containing spaces,', or", leaving paths with shell metacharacters like$,`,*,!,&,|,;sent unquoted to the terminal — allowing unintended shell expansion or command injection.Change
Always apply POSIX single-quote escaping to every dropped path, unconditionally:
This is both simpler and correct — POSIX single-quoting suppresses all shell metacharacter interpretation, and the
'\''idiom correctly handles embedded single quotes.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.