feat: add support for autokey in simple_bucket module #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@q2w can you take a look at this? |
Contributor
Author
|
@ayushmjain can you take a look? |
Contributor
Author
|
@q2w or @bharathkkb can you please review this PR? Its been pending for long time. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
This reverts commit 7f63a20.
Contributor
Author
|
@apeabody can you take a look here? This is pending since long time. |
bharathkkb
reviewed
Dec 8, 2025
Member
bharathkkb
left a comment
bharathkkb
left a comment
There was a problem hiding this comment.
Thanks for the PR @ps-occrp
Could this be managed using https://github.com/terraform-google-modules/terraform-google-kms/tree/main/modules/autokey? Bundling this into the simple module increase the surface area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for autokey in simple bucket module