-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: replace dynamic secret_manager_config block with static block #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: replace dynamic secret_manager_config block with static block #2403
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bd3a4e6 to
bf82078
Compare
|
/gcbrun |
|
Hey @apeabody , let me know if this can be merged |
fef6ae9 to
c9b8f6b
Compare
c9b8f6b to
ffd9803
Compare
|
Fixed the Merge Conflict. @apeabody please review. thanks. |
|
/gcbrun |
|
/gemini review |
Thanks @Dutta78, from the lint test: Probably some stray whitespace, 'make build' should fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request consistently replaces dynamic secret_manager_config blocks with static ones across various Terraform files and templates. This change simplifies the configuration logic, making it more straightforward to enable or disable the Secret Manager addon. The corresponding output expressions have also been updated to reflect this simplification, removing unnecessary null and length checks. This is a positive change that improves code clarity and maintainability, and addresses potential issues with dynamic block removal.
fix: use static block for secret_manager_config to prevent removal errors
Fixes: #2402