Conversation
Member
Author
|
/run pipeline |
ocofaigh
requested changes
Apr 4, 2025
Contributor
ocofaigh
left a comment
There was a problem hiding this comment.
The ibm_catalog.json should have CBR mentioned in its feature list
MatthewLemmond
previously approved these changes
Apr 4, 2025
ocofaigh
requested changes
Apr 4, 2025
| variable "cbr_enforcement_mode" { | ||
| type = string | ||
| description = "Enforcement mode of the CBR rules, valid values are `enabled`, `disabled`, or `report`. Default is report." | ||
| description = "Enforcement mode of the CBR rules, valid values are `enabled`, `disabled`, or `report`. When set to `enabled`, be aware that most traffic flow will be blocked. Default is report. [Learn more](https://cloud.ibm.com/docs/account?topic=account-context-restrictions-whatis#rule-enforcement)" |
Contributor
There was a problem hiding this comment.
this is missing the full stop at the end of the sentence.
I'm not a fan of "be aware that most traffic flow will be blocked". Can we come up with some more descriptive. Or a link that actually explains what traffic is allowed
Member
Author
There was a problem hiding this comment.
- we could link this IBM cloud doc- VPC reference architecture for IBM Cloud for Financial Services OR IBM Cloud Framework for Financial Services to
cbr_enforcement_modevariable
as we have already linked Pre-wired CBR configuration for FS Cloud to the provision_cbr variable.
OR
- update the description like below including Pre-wired CBR configuration for FS Cloud again in
cbr_enforcement_modevariable as well.
variable "cbr_enforcement_mode" {
type = string
description = "Enforcement mode of the CBR rules. Valid values are `enabled`, `disabled`, or `report`. When set to `enabled`, traffic will be restricted according to [defined rules](https://github.com/terraform-ibm-modules/terraform-ibm-cbr/tree/main/modules/fscloud), allowing only permitted connections while blocking all others. `report` mode monitors CBR rules and logged in Activity Tracker without blocking traffic which is useful for testing. Default is report. [Learn more](https://cloud.ibm.com/docs/account?topic=account-context-restrictions-whatis#rule-enforcement)."
default = "report"
}
Please suggest.
ocofaigh
approved these changes
Apr 8, 2025
Contributor
|
/run pipeline |
Contributor
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Git Issue
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Drop down added for
cbr_enforcement_mode, containing the values toenabled,disabled, orreportfor CBR rule.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers