Update geocoder.ex to include Territories #3868
Conversation
The address returned by the following link returns Territory instead of state so I have added state aliases to include this information: https://nominatim.openstreetmap.org/reverse?format=xml&lat=-35.1604&lon=149.1049&zoom=19&addressdetails=1
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Once this change is applied is it possible to update existing data? |
|
Thanks for your suggestion!
You can code a migration step which can add it for old data, not sure about the performance in this case tbh. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
|
@JakobLichterfeld I'd say, this PR makes sense.... |
Sure, but it is neither complete, nor backward compatible, nor proven to work worldwide. And is stale by OP. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
No Territory for adresses in germany. For example: https://nominatim.openstreetmap.org/reverse?format=xml&lat=48.95662066509727&lon=9.245291956117336&zoom=19&addressdetails=1 |
|
This needed to be updated as well: https://github.com/teslamate-org/teslamate/blob/336ba301a9c83703d342741f32eebbb1496dc10f/test/support/mocks/geocoder.ex |
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
3 participants
The address returned by the following link returns a territory in place of state so I have added state aliases to include this information:
https://nominatim.openstreetmap.org/reverse?format=xml&lat=-35.1604&lon=149.1049&zoom=19&addressdetails=1