Skip to content

build(deps): bump phoenix_live_view from 0.20.17 to 1.0.10 #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

build(deps): bump phoenix_live_view from 0.20.17 to 1.0.10 #4668

wants to merge 7 commits into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 18, 2025 •
edited
Loading

Bumps phoenix_live_view from 0.20.17 to 1.0.10.

Changelog

Sourced from phoenix_live_view's changelog.

1.0.10 (2025-04-17)

Bug fixes

  • Fix flash getting lost when falling back to a full page reload due to navigating across live sessions (#3686)
  • Fix edge case where locked DOM nodes were not properly patched on unlock (#3758)
  • Fix used_input? returning false when a form parameter value is a struct (#3757)
  • Catch promise rejections from pushWithReply (#3766)
  • Fix empty optgroups breaking DOM patching of other select options (#3742)
  • Don't shutdown sticky LiveViews when they push_navigate (#3612)

Enhancements

  • Allow testing phx-viewport-bottom and phx-viewport-top with Phoenix.LiveViewTest.render_hook/3 (#3755)

1.0.9 (2025-03-26)

Bug fixes

  • Fix testing uploads inside nested LiveViews with LiveViewTest (#3732)

1.0.8 (2025-03-26)

Bug fixes

  • Regression: ensure _target is sent as ["undefined"] when an input has no name (#3727)
  • Fix stream items from disconnected render not being removed when rendered inside a nested stream (#3730)

Enhancements

  • Add Phoenix.LiveViewTest.refute_redirected/1 to assert that no redirect took place (#3729)

1.0.7 (2025-03-21)

Bug fixes

  • Fix _target parameter being sent incorrectly (#3719).

1.0.6 (2025-03-20)

Bug fixes

  • Fix race condition where patches were discarded when a new navigation was already pending (#3710)
  • Fix phx-debounce="blur" re-sending events for subsequent blurs (#3689)
  • Fix code_change callback not returning the new channel state (#3712)
  • Fix LiveViews not being able to reconnect without a full page reload after a deployment that changed the router (#3715)

Enhancements

  • Improve performance of large forms (#3696)
  • Ensure JS.push values are sent on form events (#3674)
  • Allow to skip persistent_id generation in Phoenix.Component.inputs_for/1 (#3677)
  • Delay phx-disconnected binding to prevent brief flash of "Attempting to reconnect" message for short disconnects (#3680). This can be configured by passing the disconnectedTimeout option to the LiveSocket constructor.

1.0.5 (2025-02-27)

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels Apr 18, 2025
@dependabot dependabot bot mentioned this pull request Apr 18, 2025
Closed
@netlify
Copy link

netlify bot commented Apr 18, 2025 •
edited
Loading

✅ Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit b635e01
🔍 Latest deploy log https://app.netlify.com/projects/teslamate/deploys/6877565d6deca10007940649
😎 Deploy Preview https://deploy-preview-4668--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JakobLichterfeld
Copy link
Member

JakobLichterfeld commented Apr 18, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/hex/phoenix_live_view-1.0.10 branch from 31bd748 to 4925130 Compare April 18, 2025 08:56
@JakobLichterfeld JakobLichterfeld marked this pull request as draft April 18, 2025 09:03
@dependabot dependabot bot force-pushed the dependabot/hex/phoenix_live_view-1.0.10 branch from 4925130 to ce005c7 Compare April 18, 2025 09:16
@dependabot
build(deps): bump phoenix_live_view from 0.20.17 to 1.0.10
76d9871 
Bumps [phoenix_live_view](https://github.com/phoenixframework/phoenix_live_view) from 0.20.17 to 1.0.10.
- [Changelog](https://github.com/phoenixframework/phoenix_live_view/blob/v1.0.10/CHANGELOG.md)
- [Commits](phoenixframework/phoenix_live_view@v0.20.17...v1.0.10)

---
updated-dependencies:
- dependency-name: phoenix_live_view
  dependency-version: 1.0.10
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/hex/phoenix_live_view-1.0.10 branch from ce005c7 to 76d9871 Compare April 18, 2025 09:17
@JakobLichterfeld
Copy link
Member

JakobLichterfeld commented Apr 19, 2025 •
edited
Loading

Backwards incompatible changes for 1.0

LiveView 1.0 removes the client-based phx-feedback-for annotation for showing and hiding input feedback, such as validation errors. This has been replaced by Phoenix.Component.used_input?/2, which handles showing and hiding feedback using standard server rendering.

Which we use:

teslamate/test/teslamate_web/live/geofence_live_test.exs

Line 163 in 1e507ec

"<span class=\"help is-danger pl-15\" phx-feedback-for=\"geo_fence[#{kind}]\">can't be blank</span>"

@JakobLichterfeld
Copy link
Member

JakobLichterfeld commented Apr 19, 2025

Personally, I'm not a fan of "A backwards-compatible shim can be used to maintain phx-feedback-for in your existing applications:"

@JakobLichterfeld JakobLichterfeld added the note:needs investigation The issue must be investigated first label Apr 22, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 1, 2025

A newer version of phoenix_live_view exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakobLichterfeld JakobLichterfeld JakobLichterfeld approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code note:needs investigation The issue must be investigated first

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JakobLichterfeld