-
Notifications
You must be signed in to change notification settings - Fork 873
build(deps): bump tesla from 1.14.1 to 1.14.2, migrate to v2 Macro and update mix nix hash #4780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
a53494c to
7293548
Compare
|
@dependabot rebase |
Bumps [tesla](https://github.com/elixir-tesla/tesla) from 1.14.1 to 1.14.2. - [Release notes](https://github.com/elixir-tesla/tesla/releases) - [Changelog](https://github.com/elixir-tesla/tesla/blob/master/CHANGELOG.md) - [Commits](elixir-tesla/tesla@v1.14.1...v1.14.2) --- updated-dependencies: - dependency-name: tesla dependency-version: 1.14.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
7293548 to
d913b19
Compare
|
Migration needed: https://hexdocs.pm/tesla/v1-macro-migration.html |
…of soft deprecated configuration
|
@brianmay My migration is missing a crucial step. May you assist on this? It was meant for a quick deps update, this PR was the last one and I wanted to bump the hashes for nix with it as well. Turns out this dep upgrade introduced new warnings for soft-deprecation. Instead of disabling the warning I wanted to migrate according to https://hexdocs.pm/tesla/v1-macro-migration.html I'm lacking to call the correct client I assume. Hope it is a quick fix in your eyes. In the meantime I updated the nix hashes on main to avoid nix build errors, as the other dep update PRs are already merged. |
|
What step do you think is missing? |
|
I pushed a change that gets it compiling. No idea if this is correct or not though. I note the docs refer to https://hexdocs.pm/tesla/3-adapter.html This obviously needs testing :-) Also I noticed this warning at build time: Thinking this isn't actually saying we have a problem, but we should turn off the warning now we have fixed it. |
|
I think we upset dialyzer somehow. dialyzer is probably correct - most likely there is something broken somewhere, but it's messages often are undecipherable and in the wrong place :-( |
5ae23c0 to
dcb571e
Compare
|
Possibly I just fixed dialyzer. Fingers crossed. |
|
Awesome, ty!
Indeed, my assumption was correct, ty for finishing the migration! |
|
Tests fail with: |
|
Is acting like my 'name:' argument isn't working properly. I don't see the problem though, here is the docs: https://hexdocs.pm/tesla/Tesla.Adapter.Finch.html |
|
A newer version of tesla exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps tesla from 1.14.1 to 1.14.2.
Release notes
Sourced from tesla's releases.
Changelog
Sourced from tesla's changelog.
Commits
5344da9chore(master): release 1.14.2 (#764)601e7b6fix: bring back searching for mocks in ancestors (#771)c53bd1bchore(deps-dev): bump cowlib from 2.14.0 to 2.15.0 in the dev group (#770)eaf7e97chore(deps): bump gun from 2.1.0 to 2.2.0 in the prod group (#769)0218428chore: improve suggested middlewaref9a43acchore: fix code in docs8cf7745Fix race condition in Tesla.Mock.agent_set (#768)727cb0ffix: handle HTTP response trailers when use Finch + stream (#767)1196bc6fix: move regexes out of module attributes to fix compatibility with OTP 28 (...1246ae5chore(deps): bump googleapis/release-please-action from 4.1.4 to 4.2.0 (#762)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)