Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 1, 2025

Bumps tesla from 1.14.1 to 1.14.2.

Release notes

Sourced from tesla's releases.

v1.14.2

1.14.2 (2025-05-02)

Bug Fixes

  • bring back searching for mocks in ancestors (#771) (601e7b6)
  • fix race condition in Tesla.Mock.agent_set (8cf7745)
  • handle HTTP response trailers when use Finch + stream (#767) (727cb0f)
  • move regexes out of module attributes to fix compatibility with OTP 28 (#763) (1196bc6)
Changelog

Sourced from tesla's changelog.

1.14.2 (2025-05-02)

Bug Fixes

  • bring back searching for mocks in ancestors (#771) (601e7b6)
  • fix race condition in Tesla.Mock.agent_set (8cf7745)
  • handle HTTP response trailers when use Finch + stream (#767) (727cb0f)
  • move regexes out of module attributes to fix compatibility with OTP 28 (#763) (1196bc6)
Commits
  • 5344da9 chore(master): release 1.14.2 (#764)
  • 601e7b6 fix: bring back searching for mocks in ancestors (#771)
  • c53bd1b chore(deps-dev): bump cowlib from 2.14.0 to 2.15.0 in the dev group (#770)
  • eaf7e97 chore(deps): bump gun from 2.1.0 to 2.2.0 in the prod group (#769)
  • 0218428 chore: improve suggested middleware
  • f9a43ac chore: fix code in docs
  • 8cf7745 Fix race condition in Tesla.Mock.agent_set (#768)
  • 727cb0f fix: handle HTTP response trailers when use Finch + stream (#767)
  • 1196bc6 fix: move regexes out of module attributes to fix compatibility with OTP 28 (...
  • 1246ae5 chore(deps): bump googleapis/release-please-action from 4.1.4 to 4.2.0 (#762)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels Jun 1, 2025
@netlify
Copy link

netlify bot commented Jun 1, 2025

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 907377f
🔍 Latest deploy log https://app.netlify.com/projects/teslamate/deploys/687b62be0948fe0008f31922
😎 Deploy Preview https://deploy-preview-4780--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dependabot dependabot bot force-pushed the dependabot/hex/tesla-1.14.2 branch from a53494c to 7293548 Compare June 7, 2025 07:42
@JakobLichterfeld
Copy link
Member

@dependabot rebase

Bumps [tesla](https://github.com/elixir-tesla/tesla) from 1.14.1 to 1.14.2.
- [Release notes](https://github.com/elixir-tesla/tesla/releases)
- [Changelog](https://github.com/elixir-tesla/tesla/blob/master/CHANGELOG.md)
- [Commits](elixir-tesla/tesla@v1.14.1...v1.14.2)

---
updated-dependencies:
- dependency-name: tesla
  dependency-version: 1.14.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/hex/tesla-1.14.2 branch from 7293548 to d913b19 Compare June 7, 2025 07:50
@JakobLichterfeld JakobLichterfeld changed the title build(deps): bump tesla from 1.14.1 to 1.14.2 build(deps): bump tesla from 1.14.1 to 1.14.2 and update mix nix hash Jun 7, 2025
@JakobLichterfeld
Copy link
Member

Migration needed: https://hexdocs.pm/tesla/v1-macro-migration.html

@JakobLichterfeld JakobLichterfeld added the note:needs investigation The issue must be investigated first label Jun 7, 2025
@JakobLichterfeld JakobLichterfeld changed the title build(deps): bump tesla from 1.14.1 to 1.14.2 and update mix nix hash build(deps): bump tesla from 1.14.1 to 1.14.2, migrate to v2 Macro and update mix nix hash Jun 7, 2025
@JakobLichterfeld JakobLichterfeld marked this pull request as draft June 7, 2025 12:37
@JakobLichterfeld
Copy link
Member

JakobLichterfeld commented Jun 7, 2025

@brianmay My migration is missing a crucial step. May you assist on this?

It was meant for a quick deps update, this PR was the last one and I wanted to bump the hashes for nix with it as well. Turns out this dep upgrade introduced new warnings for soft-deprecation. Instead of disabling the warning I wanted to migrate according to https://hexdocs.pm/tesla/v1-macro-migration.html I'm lacking to call the correct client I assume. Hope it is a quick fix in your eyes.

In the meantime I updated the nix hashes on main to avoid nix build errors, as the other dep update PRs are already merged.

@brianmay
Copy link
Collaborator

What step do you think is missing?

@brianmay
Copy link
Collaborator

I pushed a change that gets it compiling. No idea if this is correct or not though.

I note the docs refer to recv_timeout not receive_timeout. But hopefully that is just because the docs use Hackney not Finch.

https://hexdocs.pm/tesla/3-adapter.html

This obviously needs testing :-)

Also I noticed this warning at build time:

==> tesla
Compiling 40 files (.ex)
warning: `use Tesla.Builder` and `use Tesla` are soft-deprecated. It will be removed in future major version in favor of
Runtime Configuration instead. Please share your feedback at https://github.com/elixir-tesla/tesla/discussions/732

If you can turn off this warning, add the following to your config.exs:

config :tesla, disable_deprecated_builder_warning: true

  (tesla 1.14.3) lib/tesla/builder.ex:9: Tesla.Builder."MACRO-__using__"/2
  (elixir 1.17.3) elixir_dispatch.erl:261: :elixir_dispatch.expand_macro_fun/7
  (elixir 1.17.3) elixir_dispatch.erl:156: :elixir_dispatch.dispatch_require/7
  (elixir 1.17.3) elixir_expand.erl:570: :elixir_expand.expand_block/5
  (elixir 1.17.3) elixir_expand.erl:46: :elixir_expand.expand/3
  (elixir 1.17.3) elixir_dispatch.erl:275: :elixir_dispatch.expand_quoted/7

Thinking this isn't actually saying we have a problem, but we should turn off the warning now we have fixed it.

@brianmay
Copy link
Collaborator

I think we upset dialyzer somehow.

dialyzer is probably correct - most likely there is something broken somewhere, but it's messages often are undecipherable and in the wrong place :-(

@brianmay brianmay force-pushed the dependabot/hex/tesla-1.14.2 branch from 5ae23c0 to dcb571e Compare June 10, 2025 22:41
@brianmay
Copy link
Collaborator

Possibly I just fixed dialyzer. Fingers crossed.

@JakobLichterfeld
Copy link
Member

JakobLichterfeld commented Jun 11, 2025

Awesome, ty!

I'm lacking to call the correct client I assume.

Indeed, my assumption was correct, ty for finishing the migration!

@JakobLichterfeld JakobLichterfeld removed the note:needs investigation The issue must be investigated first label Jun 11, 2025
@JakobLichterfeld JakobLichterfeld marked this pull request as ready for review June 11, 2025 14:42
@JakobLichterfeld JakobLichterfeld marked this pull request as draft June 12, 2025 08:21
@JakobLichterfeld
Copy link
Member

Tests fail with: unknown registry: TeslaMate.HTTP

@brianmay
Copy link
Collaborator

Is acting like my 'name:' argument isn't working properly.

I don't see the problem though, here is the docs: https://hexdocs.pm/tesla/Tesla.Adapter.Finch.html

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 1, 2025

A newer version of tesla exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@JakobLichterfeld JakobLichterfeld added the note:needs investigation The issue must be investigated first label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code note:needs investigation The issue must be investigated first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants