Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds get_blob_tags to client #5

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

d-a-v-e
Copy link
Contributor

@d-a-v-e d-a-v-e commented Oct 17, 2024

  • Add a new method for fetching a blobs Tags.

  • I've successfully used this new method for my own usecase which was retrieving the Malware Scanning scan result generated by Defender for Storage

  • I'm unfamiliar with devenv and how exactly to use it for testing this, the below may cover it and I can add it later once I've worked my way around it.

  def test_get_blob_tags
    client.create_block_blob(key, content, metadata: { "tag1" => "value1", "tag2" => "value2" })
  
    tags = client.get_blob_tags(key)
  
    assert_equal({ "tag1" => "value1", "tag2" => "value2" }, tags)
  end

@JoeDupuis
Copy link
Member

Thank you for the PR. I am traveling and don't have the right computer with me. I'll test it out when I am back next Monday.

@JoeDupuis
Copy link
Member

Tags are set differently than metadata, so I also added support for settings tags to test the feature.

I'm unfamiliar with devenv and how exactly to use it for testing this, the below may cover it and I can add it later once I've worked my way around it.

Yeah, I should probably set a devcontainer and a CI setup.

Thank you for the PR! I'll cut a release shortly.

@JoeDupuis JoeDupuis merged commit c44030d into testdouble:main Nov 1, 2024
1 check failed
@d-a-v-e
Copy link
Contributor Author

d-a-v-e commented Nov 1, 2024

Thanks @JoeDupuis 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants