fix missing listReplacedModules in ESM barrel file
#527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies @JakobJingleheimer, I've never really understood the mjs stuff and now CI is failing for maybe-related, but probably bitrot reasons, also pertaining to ESM. @giltayar could you please take a quick look? |
|
Oh! 🤦♂️ one sec (copy+pasta) |
I copied from the CJS file, which doesn't require them
|
Oh wow, CI caught something. Neat. |
|
@searls any chance a patch could be released for this? (And also possibly upgrade quibble to include this upstream fix testdouble/quibble#108) |
|
Landed in v3.20.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this was added in v3.20.0, it was included in the CJS barrel file, but not the ESM one.