Skip to content

Include missing configuration, license and metadata files in sdist#101

Merged
jelmer merged 1 commit into
testing-cabal:masterfrom
jugmac00:add-missing-files-to-sdist
Feb 20, 2025
Merged

Include missing configuration, license and metadata files in sdist#101
jelmer merged 1 commit into
testing-cabal:masterfrom
jugmac00:add-missing-files-to-sdist

Conversation

@jugmac00

@jugmac00 jugmac00 commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

These had been left out when the build system was switched from setuptools to hatch(ling).

This fixes #100

I have not changed the contents of the wheel, which currently only includes the fixtures folder. Please let me know if I also need to update that file. Though I have looked at popular wheel files and they do not seem to include anything except the code.


This change is Reviewable

These had been left out when the build system was switched from
setuptools to hatch(ling).
@jugmac00 jugmac00 force-pushed the add-missing-files-to-sdist branch from 182e824 to d27e2b5 Compare February 20, 2025 15:25
@jelmer jelmer merged commit 861a9f3 into testing-cabal:master Feb 20, 2025
@jugmac00 jugmac00 deleted the add-missing-files-to-sdist branch February 20, 2025 16:32
@mtelka

mtelka commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

I do see this partially (both tox.ini and BSD are there while Apache-2.0 is still missing) fixed in 4.2.3.post2, but the latest fixtures version 4.2.4.post1 is still missing the fix. Could you please add Apache-2.0 to sdist too and cut a new (latest) release?

Thank you.

@jugmac00 jugmac00 mentioned this pull request Apr 10, 2025
@jugmac00

jugmac00 commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

@mtelka I created a new ticket so things do not get lost.
#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdist is missing tox.ini, Apache-2.0 and BSD files

3 participants