Fix to-be-disabled reaction on disabled="false"#490
Open
JakubGIT wants to merge 1 commit intotesting-library:mainfrom
Open
Fix to-be-disabled reaction on disabled="false"#490JakubGIT wants to merge 1 commit intotesting-library:mainfrom
disabled="false"#490JakubGIT wants to merge 1 commit intotesting-library:mainfrom
Conversation
|
I was going to give this a +1 then I read the docs for the HTML attribute 'disabled'. A note for those to come: If you are writing semantic HTML you should not add the attribute disabled if a button is enabled. And there is no such thing as Reading the double negative probably makes you think, "Something's up?" 🤔 In JSX you should be passing a boolean value to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
.toBeDisabled()treatment of a button with attribute and value `disabled='false', which happens by web-components, see expect().toBeEnabled() fails bydisabled="false"#489Why:
disabled="false"#489disabledattribute were not evaluated correctlyHow:
element.attributes.disabled.value !== 'false'Checklist: