Skip to content

Conversation

@fehnomenal
Copy link
Contributor

Thank you for this nice project 👍

This PR simplifies the setup for the module.

Before this change you would need to install bash-env-json separately. Now you only need to load the module with

use ${bash-env-nushell.packages.${self.system}.module}/bash-env.nu

@tesujimath
Copy link
Owner

tesujimath commented Nov 5, 2024

Thanks for this, it's a nice improvement.

It didn't quite work for me. I had to adjust the visibility of lib as per this commit.

If you're happy with that, please add that commit to your PR and I'll merge it. (I suspect there may be a better way for me to pass you such a commit, but I'm lacking the GitHub-Fu for that.)

@fehnomenal
Copy link
Contributor Author

Oh yeah, sorry. I copied your changes into the branch.

Btw, I think you could have pushed/edited files directly on this branch.

Thanks for looking into it 👍

@tesujimath tesujimath merged commit 11d7ff9 into tesujimath:main Nov 5, 2024
1 check passed
@tesujimath
Copy link
Owner

Thanks!

@fehnomenal fehnomenal deleted the patch-1 branch November 5, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants