Installation Deprecation Warning #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added test for coverage
* Updated error checking in install command * Addd test for coverage
…ile in older Tethys apps
…t gen command to migrate their old setup.py files to pyproject
swainn
requested changes
Dec 2, 2025
…etup.py regardlessof the install failing or not * Added error handling and error messages to setup.py parser helper function * Moved logic that handles user input to delete the old setup.py file or not to a post process function * Removed new tethys_app-directory argument and reverted uses of it to already existing "directory" argument
swainn
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request addresses a lack of errors when installing a Tethys App that has a setup.py file. Previously, the installation process would simply fail with no error message. This merge requests adds a deprecation warning to let users know to migrate to a pyproject.toml file.
Changes Made to Code
Quality Checks