Fix code scanning alert no. 6: Incorrect conversion between integer t…

…ypes Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
tg123 · Oct 24, 2024 · 3493225 · 3493225
1 parent da53065
commit 3493225
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/libplugin/skel.go b/libplugin/skel.go
@@ -315,7 +315,7 @@ func (p *SkelPlugin) createUpstream(conn ConnMetadata, to SkelPipeTo) (*Upstream
 
 	return &Upstream{
 		Host:          host,
-		Port:          int32(port),
+		Port:          int32(port), // port is already checked to be within int32 range in SplitHostPortForSSH
 		UserName:      user,
 		IgnoreHostKey: to.IgnoreHostKey(conn),
 	}, err

diff --git a/libplugin/util.go b/libplugin/util.go
@@ -67,11 +67,11 @@ func SplitHostPortForSSH(addr string) (host string, port int, err error) {
 	h, p, err := net.SplitHostPort(host)
 	if err == nil {
 		host = h
-		port, err = strconv.Atoi(p)
-
+		parsedPort, err := strconv.ParseInt(p, 10, 32)
 		if err != nil {
 			return
 		}
+		port = int(parsedPort)
 	} else if host != "" {
 		// test valid after concat :22
 		if _, _, err = net.SplitHostPort(host + ":22"); err == nil {