Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp create snap shop account #68

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MarcosPerez16
Copy link
Collaborator

Description

As a user, I want an account connected to SnapShop

This code allows for a user to create an account using a google email. Once they have created an account, they will be redirected to the homepage to start creating lists. The Create Account link is conditionally rendered dependent on if someone is signed in or not.

Acceptance Criteria

  • There is a Create an Account feature where users can input a username and password
  • The username and password created by the user is added to our Firebase dataset
  • The user can log in and out using the username and password combination they created
  • Users lists are connected to their username and password, and users cannot access other accounts' lists

Type of Changes

feature

Testing Steps / QA Criteria

  1. Create a new google email account
  2. Go sign up using the create account page on SnapShop with the google email you just created and a password
  3. If the creation is successful, you will get a success message and be redirected to the homepage
  4. Check firebase console to see your new account linked
  5. Sign out of the app, then try signing back in and check if items added and lists are updated for the correct user

… in CreateAccount.jsx to utillize `addUserToDatabase` function for account creation. Added name input for account creation.
…d utility class whitespace-nowrap to prevent text from wrapping within its container.
…ect the user to the homepage to create a new list.
…k in the nav bar depending on if a user is signed in or not.
Copy link

Visit the preview URL for this PR (updated for commit a51aabb):

https://tcl-76-smart-shopping-list--pr68-mp-create-snapshop-a-hfp4qb3c.web.app

(expires Fri, 25 Oct 2024 12:07:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

Copy link
Collaborator

@sar-mko sar-mko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to make two accounts one that was gmail and one that wasn't. And so only the gmail can get authorized and re-logged into.

Though I am wondering if there's a way that we can just use the firebase CLI pop up instead of having a create account page for the time being? It's confusing because we can sign up with any kind of email, but the sign in uses the firebase popup, and it does google verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants