Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting item off the list #29

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Deleting item off the list #29

merged 4 commits into from
Sep 21, 2024

Conversation

Hudamabkhoot
Copy link
Collaborator

Description

Users can now delete list items to help them keep their lists tidy by clicking the delete button next to the items on their lists. Users will be shown a prompt to confirm or cancel the item deletion upon clicking that button.

Related Issue

closes #12

Acceptance Criteria

  • The ListItem component renders a button that allows the user to delete an item from their list when clicked
  • Clicking the delete button prompts the user to confirm that they really want to delete the item
  • The deleteItem function in api/firebase.js has been filled out, and deletes the item from the Firestore database

Type of Changes

Feature

Updates

Before

Screenshot 2024-09-16 at 13 52 47

After

Screenshot 2024-09-16 at 14 02 11

Testing Steps / QA Criteria

  • Do a git pull and git checkout hm-mm-deleteItem.
  • Open the homepage by running npm start.
  • Navigate to the List page and you'll find a delete button next to each item.
  • Clicking the delete button will show a prompt to confirm deletion; by clicking ok the item will be removed from Firebase and a success message will be displayed, otherwise a deletion canceled message will be displayed.

Copy link

github-actions bot commented Sep 16, 2024

Visit the preview URL for this PR (updated for commit e21a512):

https://tcl-79-smart-shopping-list--pr29-hm-mm-deleteitem-dwihflzw.web.app

(expires Mon, 23 Sep 2024 13:18:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

Copy link
Collaborator

@Wyna-7 Wyna-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work :)

Copy link
Collaborator

@joriordan332 joriordan332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Well done guys

Copy link
Member

@hariscs hariscs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is one issue, when I type the number item name in the field, it accepts it and when I go to my list it displays only the button.
@Hudamabkhoot @marshjaja

ref image
image

@Hudamabkhoot Hudamabkhoot merged commit 825f492 into main Sep 21, 2024
2 checks passed
@Hudamabkhoot Hudamabkhoot deleted the hm-mm-deleteItem branch September 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants