Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent dark and light theme throughout app #52

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

joriordan332
Copy link
Collaborator

Description

Code now allows for consistency with the users dark/light theme preference so that when they log in and go to the home page and if they have selected dark for example the theme will stay dark and vice versa.

Related Issue

Closes #43

Acceptance Criteria

  • Lift the state to the App and add the toggle button on the Login view.
  • Fix the back ground colour to be the app's background colour.

Type of Changes

Enhancement

Updates

Before

image image

After

Light
image
image
Dark
image
image

Testing Steps / QA Criteria

  • Do a git pull and then git checkout jo-dark-light-login
  • Open the login page by running npm start
  • Once there test out the dark/light mode consistency by logging in and out to see if the theme stays the same when navigating back and forth between each page

Copy link

github-actions bot commented Oct 11, 2024

Visit the preview URL for this PR (updated for commit 71e6303):

https://tcl-79-smart-shopping-list--pr52-jo-dark-light-login-e8ro5t2v.web.app

(expires Sun, 20 Oct 2024 12:20:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

src/views/Login.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@marshjaja marshjaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Collaborator

@Hudamabkhoot Hudamabkhoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @joriordan332 👏 i think saving the mode choice in local storage in the context would be great here since now it wont save if the page is reloaded.

@joriordan332 joriordan332 merged commit 6dcc2cf into feat/setup-tailwind-shadcn Oct 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants