Add/analysis overview query #2970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshathakuri
force-pushed
the
add/analysis-overview-query
branch
from
a160364 to
621961c
Compare
barshathakuri
force-pushed
the
add/analysis-overview-query
branch
3 times, most recently
from
84c8175 to
9324507
Compare
AdityaKhatri
requested changes
Jul 18, 2024
|
|
||
| const error = getErrorObject(riskyError); | ||
|
|
||
| /* |
Collaborator
There was a problem hiding this comment.
yo block nai hatauda huncha
|
|
||
| const onDeleteConfirmClick = useCallback(() => { | ||
| onDelete(pillarId); | ||
| onDelete(Number(pillarId)); |
Collaborator
There was a problem hiding this comment.
Leave a TODO here as well
| statusLabel = _ts('analysis', 'noAnalysisTagLabel'); | ||
| } | ||
|
|
||
| const disabled = pendingPillarDelete; |
Collaborator
There was a problem hiding this comment.
We need this, don't we?
| analyzedEntries: data.analyzedEntriesCount, | ||
| projectId: activeProject, | ||
| title: data.title, | ||
| pendingPillarDelete: pendingPillarDelete && data.id === deletePillarId, |
Collaborator
There was a problem hiding this comment.
Are we moving this inside?
| className={styles.pillarAnalyses} | ||
| headerClassName={styles.pillarAnalysesHeader} | ||
| heading={_ts('analysis', 'pillarAnalysisCount', { count: pillars.length })} | ||
| heading={_ts('analysis', 'pillarAnalysisCount', { count: pillars?.length })} |
Collaborator
There was a problem hiding this comment.
Lets remove _ts and replace this directly with a text.
Comment on lines
200
to
202
| const timelineLabelSelector = (d: TimelineData): string => d.label; | ||
| const timelineValueSelector = (d: TimelineData): number => d.value; | ||
| const timelineKeySelector = (d: TimelineData): string => d.key; |
| const totalLeadsCount = analysisSummaryData | ||
| ?.project?.analysisOverview?.totalLeadsCount; | ||
|
|
||
| const analysisRendererParams = useCallback((id: string, data: AnalysisSummaryType) => ({ |
Collaborator
There was a problem hiding this comment.
Add return time in renderer params for better typecheck
barshathakuri
force-pushed
the
add/analysis-overview-query
branch
from
9324507 to
1f6da74
Compare
AdityaKhatri
requested changes
Aug 30, 2024
| }, [setModalHidden, triggerGetAnalysis, retriggerAnalysisOverview]); | ||
| }, [setModalHidden, getProjectAnalysis]); | ||
|
|
||
| const handleAnalysisEditClick = useCallback((analysisId: number | undefined) => { |
Collaborator
There was a problem hiding this comment.
Please do not undo this
|
|
||
| interface AnalysisDashboardProps { | ||
| className?: string; | ||
| analysisId: string; |
AdityaKhatri
force-pushed
the
add/analysis-overview-query
branch
2 times, most recently
from
6866c77 to
7ab476d
Compare
AdityaKhatri
force-pushed
the
add/analysis-overview-query
branch
4 times, most recently
from
81ee1a1 to
4f874bf
Compare
AdityaKhatri
force-pushed
the
add/analysis-overview-query
branch
from
4f874bf to
e2835f2
Compare
shreeyash07
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Depends on: the-deep/server#1516
Changes
This PR doesn't introduce any:
console.logmeant for debuggingThis PR contains valid: